fix: couple of changes #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change from 2.5 missing on 2.6 - version/branch from components - generated bundle with rbac - linter Signed-off-by: Wen Zhou <[email protected]>
Signed-off-by: Wen Zhou <[email protected]>
zdtsw
added a commit
that referenced
this pull request
Jan 19, 2024
* sync: from main to rhoai-2.6 (#163) * Add recording and alerting rules for TrustyAI Update SOP url, RHODS to RHOAI Fix trustyai-alerting.rules indentation * fix(kserve): check on multiple depends operators if all pre-installed (opendatahub-io#744) Signed-off-by: Wen Zhou <[email protected]> * update: rewrite func to check operator (opendatahub-io#745) creds to: @bartoszmajsak Signed-off-by: Wen Zhou <[email protected]> * fix(cleanup): cleans up dependant resources (opendatahub-io#748) * feat: implements failing test for deletion using configmap * fix(cleanup): cleans up dependant resources The code responsible for cleaning up resources on cfg map presence was failing early due to operations on nil list instance of KfDef resources, leading to panic and restart of the pod making an impression that cleanup takes forever * fix(reconcile): requeue only when actual error happens Original code was always causing requeue as even if upgrade.OperatorUninstall(r.Client, r.RestConfig) resulted in nil error (success), it was wrapped in error with message error while operator uninstall: <nil> * fix: reverts img placeholder in kustomize * fix: removes commented out code * fix(features): makes rest config loader more flexible (opendatahub-io#760) * add table of contents to readme (opendatahub-io#769) * Makefile: add clean target (opendatahub-io#733) Add `make clean` which removes build artefacts. At the moment it's ./bin, ./odh-manifests/* and cover.out from test target. Do not remove odh-manifests directory since it is commited to VCS. In the recipe chown of $(LOCALBIN) since setup-envtest makes its dir RO for some reason [1]. Related: opendatahub-io#696 [1] https://github.com/kubernetes-sigs/controller-runtime/blob/main/tools/setup-envtest/store/store.go#L191 Signed-off-by: Yauheni Kaliuta <[email protected]> * chore: cleanup owns on RS,Pod, daemonset, CRD (opendatahub-io#777) * chore: cleanup owns on RS,Pod, daemonset, CRD * cleanup: remove developmentconfig not in use * chore: move rbac into one file and remove duplicated one --------- Signed-off-by: Wen Zhou <[email protected]> * update(kserve): add monitoring logic (opendatahub-io#782) Signed-off-by: Wen Zhou <[email protected]> * chore(mesh): Use third party service account tokens (opendatahub-io#767) This should allow Service Mesh to run on any OpenShift flavor. Fixes opendatahub-io/kserve#138 Signed-off-by: Edgar Hernández <[email protected]> * chore: change log info for monitoring patch namespace (opendatahub-io#787) Signed-off-by: Wen Zhou <[email protected]> * fix devflags empty object (opendatahub-io#659) - change DefFlags to pointer type , see reason from example: https://www.sohamkamani.com/golang/omitempty/ - change both in DSC and DSCI * feature: add support for unmanaged and remove for servicemesh and serverless (opendatahub-io#781) * feature: add support for unmanaged and remove for servicemesh and serverless Signed-off-by: Wen Zhou <[email protected]> * Update components/kserve/kserve.go Co-authored-by: Bartosz Majsak <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: Bartosz Majsak <[email protected]> * fix(nilpointer): when more than one DSCI CR in cluster (opendatahub-io#756) * fix(nilpointer): when more than one DSCI CR in cluster - use the one with ealiest timestamp as the default one - suggest user to delete other CR but only use default one - only set the extra/wrong DSCI in Error status Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: Bartosz Majsak <[email protected]> * chore: change label name (opendatahub-io#790) - use a more generaic label than bind to namespace name Signed-off-by: Wen Zhou <[email protected]> * Remove lavlas from OWNERS (opendatahub-io#791) * fix(builder): initializes rest config before invoking any partial builder (opendatahub-io#792) This way we can obtain interact with the cluster from partial builders instead of defering it to Apply phase. * chore: shifts FeatureTracker creation to Feature's Apply phase (opendatahub-io#795) * fix(mesh): disables default network policy management (opendatahub-io#798) * fix: disables default network policy management * fix: returns correct error Co-authored-by: Wen Zhou <[email protected]> --------- Co-authored-by: Wen Zhou <[email protected]> * feat(linters): Enable all linters by default. (opendatahub-io#692) --------- Signed-off-by: Wen Zhou <[email protected]> Signed-off-by: Yauheni Kaliuta <[email protected]> Signed-off-by: Edgar Hernández <[email protected]> Co-authored-by: Rui Vieira <[email protected]> Co-authored-by: Bartosz Majsak <[email protected]> Co-authored-by: Ajay Jaganathan <[email protected]> Co-authored-by: Yauheni Kaliuta <[email protected]> Co-authored-by: Edgar Hernández <[email protected]> Co-authored-by: Landon LaSmith <[email protected]> * update: rebranding for rhoai from rhods (#160) * update: rebranding for rhoai from rhods Signed-off-by: Wen Zhou <[email protected]> * Update: new icon data and link to dashboard icon Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> * fix: couple of changes (#164) * fix: couple of changes - change from 2.5 missing on 2.6 - version/branch from components - generated bundle with rbac - linter Signed-off-by: Wen Zhou <[email protected]> * [cherry-pick]: odh opendatahub-io#809 Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> * update(trustyai): set component by default as Managed as GA in 2.6 Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> Signed-off-by: Yauheni Kaliuta <[email protected]> Signed-off-by: Edgar Hernández <[email protected]> Co-authored-by: Rui Vieira <[email protected]> Co-authored-by: Bartosz Majsak <[email protected]> Co-authored-by: Ajay Jaganathan <[email protected]> Co-authored-by: Yauheni Kaliuta <[email protected]> Co-authored-by: Edgar Hernández <[email protected]> Co-authored-by: Landon LaSmith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://issues.redhat.com/browse/RHOAIENG-1949