Skip to content

Conversation

@samsonasik
Copy link
Member

reduce syntax errors from : 383 to 14:

Before:

Syntax error found in 383 files

After:

Syntax error found in 14 files

@samsonasik samsonasik enabled auto-merge (squash) May 7, 2021 13:48
'('
);

return $content;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be handled by Rector. If not, there is a bug somewhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this for handilng phpstan's vendor of ondrejmirtes/better-reflection/src that somehow not downgrade the code.

Copy link
Member

@TomasVotruba TomasVotruba May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All packages must be downgraded by Rector. scoper.php is only for tweaking class names for autoload edge cases.

We need to figure out why this downgrade is missed. Maybe its in exlcuded paths in downgrade config for Rector?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some probably caused by exclude config :

'vendor/symfony/http-kernel/HttpKernelBrowser.php',
'vendor/symfony/http-foundation/Session/*',
'vendor/symfony/string/Slugger/AsciiSlugger.php',
'vendor/symfony/cache/*',
'nette/caching/src/Bridges/*',
// This class has an issue for PHP 7.1:
// https://github.com/rectorphp/rector/issues/4816#issuecomment-743209526
// It doesn't happen often, and Rector doesn't use it, so then
// we simply skip downgrading this class
'vendor/symfony/dependency-injection/ExpressionLanguage.php',
'vendor/symfony/dependency-injection/ExpressionLanguageProvider.php',
'vendor/symfony/var-dumper/Caster/*',

other probably need re-sort the directories.

I will check more.

@samsonasik samsonasik merged commit 6ddb145 into main May 7, 2021
@samsonasik samsonasik deleted the reduce-errors branch May 7, 2021 14:02
TomasVotruba added a commit that referenced this pull request Oct 12, 2024
rectorphp/rector-src@61016bf [CodeQuality] Use existing PhpAttributeAnalyzer service instead of AttributeFinder from Doctrine package on DynamicDocBlockPropertyToNativePropertyRector (#6382)
TomasVotruba added a commit that referenced this pull request Oct 15, 2024
rectorphp/rector-src@61016bf [CodeQuality] Use existing PhpAttributeAnalyzer service instead of AttributeFinder from Doctrine package on DynamicDocBlockPropertyToNativePropertyRector (#6382)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants