Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Remove RenameClassNonPhpRector from the defaults #6373

Merged
merged 1 commit into from
May 6, 2021

Conversation

sabbelasichon
Copy link
Contributor

Resolves: #6361

@sabbelasichon
Copy link
Contributor Author

@TomasVotruba We have to be aware that this is breaking form some people. So i added it to the template file to show people that this has changed.

Comment on lines 21 to 23

// Non PHP Changes - To keep the old behaviour =< 0.10.5 add this
// $services->set(RenameClassNonPhpRector::class);
Copy link
Member

@TomasVotruba TomasVotruba May 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed, as template is always generated with the latest Rector version.

But the documentation for there non-PHP changes might be needed to explain it

@TomasVotruba
Copy link
Member

Btw, what set configs this rule should be included in?

@sabbelasichon
Copy link
Contributor Author

I don´t know. Never used this. Where does it come from?

@TomasVotruba
Copy link
Member

TomasVotruba commented May 6, 2021

I think it was extacted from RenameClassRector where the class should be renamed in framework specific non-PHP files too:

  • Laravel → .blade.php
  • Nette → .neon
  • Symfony → .xml, .yaml

@sabbelasichon
Copy link
Contributor Author

sabbelasichon commented May 6, 2021

If you like i could add it to the sets of these framework packages and we should be fine.
Btw. the whole documentation part goes here: #6374

@TomasVotruba
Copy link
Member

TomasVotruba commented May 6, 2021

add it to the sets of these framework packages and we should be fine

That would be great 👍 🙇

The 3 above should be fine. Thanks & thanks 🙂

sabbelasichon added a commit to sabbelasichon/rector-nette that referenced this pull request May 6, 2021
[TASK] Add RenameClassNonPhpRector

see: rectorphp/rector#6373
sabbelasichon added a commit to sabbelasichon/rector-symfony that referenced this pull request May 6, 2021
sabbelasichon added a commit to sabbelasichon/rector-laravel that referenced this pull request May 6, 2021
TomasVotruba pushed a commit to driftingly/rector-laravel that referenced this pull request May 6, 2021
TomasVotruba pushed a commit to rectorphp/rector-symfony that referenced this pull request May 6, 2021
lightningcraft-0201 added a commit to lightningcraft-0201/Rector that referenced this pull request Oct 16, 2023
TomasVotruba added a commit that referenced this pull request Oct 11, 2024
rectorphp/rector-src@52e3fdf [TypeDeclaration] Fix deep nested array docblock with \ prefix on ReturnTypeFromStrictNewArrayRector (#6373)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running the process command without defining a rule is still processing
2 participants