-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Remove RenameClassNonPhpRector from the defaults #6373
Conversation
@TomasVotruba We have to be aware that this is breaking form some people. So i added it to the template file to show people that this has changed. |
templates/rector.php.dist
Outdated
|
||
// Non PHP Changes - To keep the old behaviour =< 0.10.5 add this | ||
// $services->set(RenameClassNonPhpRector::class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed, as template is always generated with the latest Rector version.
But the documentation for there non-PHP changes might be needed to explain it
Btw, what set configs this rule should be included in? |
I don´t know. Never used this. Where does it come from? |
I think it was extacted from
|
If you like i could add it to the sets of these framework packages and we should be fine. |
That would be great 👍 🙇 The 3 above should be fine. Thanks & thanks 🙂 |
[TASK] Add RenameClassNonPhpRector see: rectorphp/rector#6373
rectorphp/rector-src@52e3fdf [TypeDeclaration] Fix deep nested array docblock with \ prefix on ReturnTypeFromStrictNewArrayRector (#6373)
Resolves: #6361