[Experiment] [NodeTypeResolver] Remove no longer needed deep Expr visitor ExprScopeFromStmtNodeVisitor #6223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…romStmtNodeVisitor
samsonasik
changed the title
|
All checks have passed 🎉 @TomasVotruba I think it is ready. For note: this can be reverted in the future if there is code with deep Expr that phpstan can't locate, and that will require new fixture to proof. I will also check on some projects in case of regression in other projects. |
samsonasik
changed the title
TomasVotruba
approved these changes
Aug 7, 2024
|
Lets try this in the wild 👌 |
|
Hello, after deleting this piece of code, I encountered issues with using the match operator. Here is a link to the demo https://getrector.com/demo/4750277e-8fdc-4a2f-8bf0-b6aa76090e8f |
|
@shutnic I will look into that,note to myself: in phpstan 1.11+, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems deep expr scope visitor no longer needed. This PR remove it.