[CodeQuality] Skip Generator on SimplifyForeachToCoalescingRector (#…

…6221)

* [CodeQuality] Skip Generator on SimplifyForeachToCoalescingRector

* [CodeQuality] Skip Generator on SimplifyForeachToCoalescingRector

* ensure array type

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <[email protected]>

rules-tests/CodeQuality/Rector/Foreach_/SimplifyForeachToCoalescingRector/Fixture/fixture2.php.inc

@@ -1,8 +1,9 @@
 <?php
 
-function simplifyForeachToCoalescing2()
+function simplifyForeachToCoalescing2($currentFunction)
 {
-    foreach ($this->oldToNewFunctions as $oldFunction => $newFunction) {
+    $oldToNewFunctions = ['a' => 'b'];
+    foreach ($oldToNewFunctions as $oldFunction => $newFunction) {
         if ($oldFunction === $currentFunction) {
             return $newFunction;
         }
@@ -15,9 +16,10 @@ function simplifyForeachToCoalescing2()
 -----
 <?php
 
-function simplifyForeachToCoalescing2()
+function simplifyForeachToCoalescing2($currentFunction)
 {
-    return $this->oldToNewFunctions[$currentFunction] ?? 45;
+    $oldToNewFunctions = ['a' => 'b'];
+    return $oldToNewFunctions[$currentFunction] ?? 45;
 }
 
 ?>

rules-tests/CodeQuality/Rector/Foreach_/SimplifyForeachToCoalescingRector/Fixture/foreach_key_value.php.inc

@@ -7,7 +7,7 @@ class ForeachKeyValue
     /**
      * @var mixed[]
      */
-    private $oldToNewOption = [];
+    private array $oldToNewOption = [];
 
     public function run()
     {
@@ -33,7 +33,7 @@ class ForeachKeyValue
     /**
      * @var mixed[]
      */
-    private $oldToNewOption = [];
+    private array $oldToNewOption = [];
 
     public function run()
     {

rules-tests/CodeQuality/Rector/Foreach_/SimplifyForeachToCoalescingRector/Fixture/skip_generator.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Foreach_\SimplifyForeachToCoalescingRector\Fixture;
+
+final class SkipGenerator
+{
+    public function load(): \Generator
+    {
+        foreach (['a' => 1, 'b' => 2] as $key => $value) {
+            yield $key => $value;
+        }
+    }
+
+    public function loadByKey(string $name): ?int
+    {
+        foreach ($this->load() as $key => $value) {
+            if ($key === $name) {
+                return $value;
+            }
+        }
+        return null;
+    }
+}

rules/CodeQuality/Rector/Foreach_/SimplifyForeachToCoalescingRector.php

@@ -169,6 +169,11 @@ private function matchForeachReturnOrAssign(Foreach_ $foreach): Expression|Retur
             return null;
         }
 
+        $foreachExprType = $this->nodeTypeResolver->getNativeType($foreach->expr);
+        if (! $foreachExprType->isArray()->yes()) {
+            return null;
+        }
+
         $innerStmt = $if->stmts[0];
         if ($innerStmt instanceof Return_) {
             return $innerStmt;