Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to main: AzureML migration to v2 #2137

Merged
merged 17 commits into from
Jul 31, 2024
Merged

Staging to main: AzureML migration to v2 #2137

merged 17 commits into from
Jul 31, 2024

Conversation

miguelgfierro
Copy link
Collaborator

Description

Adding the latest changes in AzureML.

Related Issues

There is still this issue unfixed #2133 which is breaking the tests (both stating and main). However, it is not a problem with the code itself, it is just that the dataset URL is broken.

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

miguelgfierro and others added 17 commits July 13, 2024 09:33
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Review test readme and define best practices
Added free course on Recommendation systems
* Migrate AML SDK from v1 to v2

Signed-off-by: Simon Zhao <[email protected]>

* Correct MLClient constructor paramenter names

Signed-off-by: Simon Zhao <[email protected]>

* Remove unsupported operation begin_start() on AmlCompute

Signed-off-by: Simon Zhao <[email protected]>

* Add label for environments.get()

Signed-off-by: Simon Zhao <[email protected]>

* Remove environment get

Signed-off-by: Simon Zhao <[email protected]>

* Update

Signed-off-by: Simon Zhao <[email protected]>

* Correct experiment and environment names

Signed-off-by: Simon Zhao <[email protected]>

* Correct compute

Signed-off-by: Simon Zhao <[email protected]>

* Create Conda env inside Dockerfile

Signed-off-by: Simon Zhao <[email protected]>

* Catch ResourceNotFoundError

Signed-off-by: Simon Zhao <[email protected]>

* Correct experiment name

Signed-off-by: Simon Zhao <[email protected]>

* Update env creation and job running

Signed-off-by: Simon Zhao <[email protected]>

* Try waiting for completion by stream

Signed-off-by: Simon Zhao <[email protected]>

* Try to fix conda activate

Signed-off-by: Simon Zhao <[email protected]>

* Import sys

Signed-off-by: Simon Zhao <[email protected]>

* Change logging level

Signed-off-by: Simon Zhao <[email protected]>

* Exit directly once pytest fails

Signed-off-by: Simon Zhao <[email protected]>

* Set numpy<2.0.0 due to issue of cornac

Signed-off-by: Simon Zhao <[email protected]>

* Correct Dockerfile

Signed-off-by: Simon Zhao <[email protected]>

* Change heredoc

Signed-off-by: Simon Zhao <[email protected]>

* Set dockerfile version

Signed-off-by: Simon Zhao <[email protected]>

* Copy environment.yml to container

Signed-off-by: Simon Zhao <[email protected]>

* Update .github/actions/azureml-test/action.yml

Co-authored-by: Miguel Fierro <[email protected]>

* Update as suggested by Andreas

* Print pytest logs

Signed-off-by: Simon Zhao <[email protected]>

* Group outputs

Signed-off-by: Simon Zhao <[email protected]>

* Install pip in conda env, and show pytest warnings

Signed-off-by: Simon Zhao <[email protected]>

* Add command name

Signed-off-by: Simon Zhao <[email protected]>

* Update

Signed-off-by: Simon Zhao <[email protected]>

* Show warnings in pytest

Signed-off-by: Simon Zhao <[email protected]>

* Show warnings in pytest

Signed-off-by: Simon Zhao <[email protected]>

---------

Signed-off-by: Simon Zhao <[email protected]>
Co-authored-by: Miguel Fierro <[email protected]>
@miguelgfierro miguelgfierro merged commit 4f86e47 into main Jul 31, 2024
74 of 85 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 31, 2024
Staging to main: AzureML migration to v2
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants