Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in README.md #2109

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fix typo in README.md #2109

merged 1 commit into from
Jun 10, 2024

Conversation

Kingston257
Copy link
Contributor

Description

Make the following grammatical corrections to line 97 of the README file:

  • "has into account" should be "takes into account".
  • "Riemannian conjugate gradients optimization" should be "Riemannian conjugate gradient optimization" (singular form).
  • "and following a geometric approach" should be "and follows a geometric approach".

Related Issues

None

References

Uhmm... Dictionary?

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

@Kingston257
Fix typo in README.md
8827772 
Made the following grammatical corrections to line 97 of the file:
- "has into account" should be "takes into account".
- "Riemannian conjugate gradients optimization" should be "Riemannian conjugate gradient optimization" (singular form).
- "and following a geometric approach" should be "and follows a geometric approach".
@miguelgfierro miguelgfierro changed the base branch from main to staging June 10, 2024 12:46
@miguelgfierro
Copy link
Collaborator

Thanks @Kingston257 for your first contribution, and congrats!

Btw, I have changed the target branch to staging, which is our development branch.

@miguelgfierro miguelgfierro merged commit f9d7e64 into recommenders-team:staging Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@SimonYansenZhao SimonYansenZhao Awaiting requested review from SimonYansenZhao SimonYansenZhao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kingston257 @miguelgfierro