Flake8 Fixes (Part 2) #1552
Merged
Flake8 Fixes (Part 2) #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laserprec
force-pushed
the
laserprec/flake8-fix-p2
branch
from
9ac4543
to
0d2d874
Compare
laserprec
force-pushed
the
laserprec/flake8-fix-p2
branch
from
0d2d874
to
a1a012f
Compare
Closed
added 8 commits
October 20, 2021 15:38
laserprec
force-pushed
the
laserprec/flake8-fix-p2
branch
from
4a2396f
to
780cb03
Compare
laserprec
requested review from
anargyri,
gramhagen,
loomlike,
miguelgfierro,
wutaomsft and
yueguoguo
as code owners
anargyri
reviewed
Oct 21, 2021
anargyri
reviewed
Oct 21, 2021
anargyri
reviewed
Oct 21, 2021
anargyri
reviewed
Oct 21, 2021
anargyri
reviewed
Oct 21, 2021
anargyri
reviewed
Oct 21, 2021
anargyri
reviewed
Oct 21, 2021
anargyri
reviewed
Oct 21, 2021
anargyri
reviewed
Oct 21, 2021
anargyri
reviewed
Oct 21, 2021
anargyri
reviewed
Oct 21, 2021
| @@ -221,7 +221,7 @@ def evaluation_log_hook( | |||
| batch_size (int): Number of samples fed into the model at a time. | |||
| Note, the batch size doesn't affect on evaluation results. | |||
| eval_fns (iterable of functions): List of evaluation functions that have signature of | |||
| (true_df, prediction_df, \*\*eval_kwargs)->(float). If None, loss is calculated on true_df. | |||
| (true_df, prediction_df, **eval_kwargs)->(float). If None, loss is calculated on true_df. | |||
There was a problem hiding this comment.
Isn't this going to have a different effect i.e. make the text bold? https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html?highlight=asterisk#inline-markup
There was a problem hiding this comment.
I think this bolds the text only if it is encapsulated on both sides ( **eval_kwargs**), but I can compile the docs and confirm.
Codecov Report
@@ Coverage Diff @@
## staging #1552 +/- ##
============================================
+ Coverage 0.00% 62.13% +62.13%
============================================
Files 84 84
Lines 8436 8437 +1
============================================
+ Hits 0 5242 +5242
- Misses 0 3195 +3195
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
LGTM |
anargyri
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the part 2 of the flake8 fixes. For part 1, please see #1550.
The following flake8 issues are addressed in this PR. For lines contained in our code coverage, source code fixes are applied whenever possible. For lines outside our code coverage, flake8 exception is made as an inline comment (e.g.
# noqa: <PEP 8 RULE>).Coding Convention Issues
Critical issues (can be indication of potential bugs)
For Reviewers, please direct your attention to commits marked with (**), as they may indicate some critical logical issues.
Checklist:
staging branchand not tomain branch.