Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Surprise and Python 3.7 #1540

Merged
merged 3 commits into from
Sep 30, 2021
Merged

Fix Surprise and Python 3.7 #1540

merged 3 commits into from
Sep 30, 2021

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Sep 28, 2021 •
edited
Loading

Description

  • Install Surprise from tarball in setup.py. This fixes incompatibilities with certain numpy versions.
  • Tested Python 3.7 with venv and virtualenv
  • Updated dockerfile to 3.7

Related Issues

#1511

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

laserprec
laserprec reviewed Sep 28, 2021
View reviewed changes
setup.py
@@ -43,7 +43,8 @@
"pyyaml>=5.4.1,<6",
"requests>=2.0.0,<3",
"cornac>=1.1.2,<2",
"scikit-surprise>=0.19.1,<=1.1.1",
# For Surprise, specify the tarball in order to avoid incompatibilities of compiled .pyx files with numpy versions < 1.20
"scikit-surprise@https://files.pythonhosted.org/packages/97/37/5d334adaf5ddd65da99fc65f6507e0e4599d092ba048f4302fe8775619e8/scikit-surprise-1.1.1.tar.gz",
Copy link
Contributor

@laserprec laserprec Sep 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome solution to the problem!

miguelgfierro
miguelgfierro approved these changes Sep 30, 2021
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anargyri anargyri merged commit 448982d into staging Sep 30, 2021
@miguelgfierro miguelgfierro deleted the andreas/python37 branch October 4, 2021 09:45
@laserprec laserprec mentioned this pull request Oct 7, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laserprec laserprec laserprec left review comments

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anargyri @miguelgfierro @laserprec