Merge pull request #2164 from recommenders-team/hotfix-2163

Fix #2163
recommenders-team · Sep 9, 2024 · edca084 · edca084
2 parents 7b32452 + 84497f2
commit edca084
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/recommenders/models/deeprec/DataModel/ImplicitCF.py b/recommenders/models/deeprec/DataModel/ImplicitCF.py
@@ -206,6 +206,8 @@ def train_loader(self, batch_size):
         """
 
         def sample_neg(x):
+            if len(x) >= self.n_items:
+                raise ValueError("A user has voted in every item. Can't find a negative sample.")
             while True:
                 neg_id = random.randint(0, self.n_items - 1)
                 if neg_id not in x: