Skip to content

Commit

Permalink
Not triggering unit tests on Draft PR (#2033)
Browse files Browse the repository at this point in the history
* Not triggering unit tests on Draft PR

Signed-off-by: Jun Ki Min <[email protected]>

* Change a PR-triggering file to test

Signed-off-by: Jun Ki Min <[email protected]>

---------

Signed-off-by: Jun Ki Min <[email protected]>
  • Loading branch information
loomlike authored Nov 3, 2023
1 parent 2c6b258 commit 4ee5262
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/azureml-unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ on:
- tests/**
- '!tests/**/*.md'
- setup.py
types: [opened, synchronize, reopened, ready_for_review]

# Enable manual trigger
workflow_dispatch:
Expand Down Expand Up @@ -46,6 +47,7 @@ jobs:
shell: bash
outputs:
test_groups: ${{ steps.get_test_groups.outputs.test_groups }}
if: github.event.pull_request.draft == false

execute-tests:
needs: get-test-groups
Expand All @@ -69,3 +71,4 @@ jobs:
AZUREML_TEST_SUBID: ${{ secrets.AZUREML_TEST_SUBID }}
PYTHON_VERSION: ${{ matrix.python-version }}
TEST_GROUP: ${{ matrix.test-group }}
if: github.event.pull_request.draft == false
1 change: 0 additions & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ def spark(tmp_path_factory, app_name="Sample", url="local[*]"):
Returns:
SparkSession: new Spark session
"""

with TemporaryDirectory(dir=tmp_path_factory.getbasetemp()) as td:
config = {
"spark.local.dir": td,
Expand Down

0 comments on commit 4ee5262

Please sign in to comment.