fix: bump ceramic package versions to 6.x #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smrz2001
commented
Aug 5, 2024
| @@ -17,4 +17,4 @@ COPY src/ ./src | |||
| # Select all tests by default | |||
| ENV TEST_SELECTOR "correctness" | |||
|
|
|||
| ENTRYPOINT ["/app/entrypoint.sh", "run", "test", "--forceExit", "--testPathPattern", "$TEST_SELECTOR"] | |||
| ENTRYPOINT ["/app/entrypoint.sh", "run", "test", "--testPathPattern", "$TEST_SELECTOR"] | |||
There was a problem hiding this comment.
This is ok because the test directive in package.json already adds --forceExit to the jest command.
smrz2001
force-pushed
the
feature/aes-293-correctness-test-are-failing-typescript-module-failure
branch
from
f0ba646 to
443a3b3
Compare
smrz2001
deleted the
feature/aes-293-correctness-test-are-failing-typescript-module-failure
branch
|
huh, I wonder why the tests didn't break right away after we released the 6.x versions, but only broke after a few weeks. I wonder if we have a package somewhere that started depending on the 6.x versions but didn't increase it's own major version as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested against QA and all
correctnesstests passed.