[SYCL][Doc] Remove graph property for buffer host lifetime #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed Greg's most recent feedback points: * [Don't need the assume_data_outlives_buffer](intel#10473 (comment)) * [Move graph_support_level namespace](intel#10473 (comment))
EwanC
pushed a commit
that referenced
this pull request
Aug 28, 2023
Implements spec feedback to remove this property, goes with spec PR #311
mfrancepillois
approved these changes
Aug 28, 2023
EwanC
pushed a commit
that referenced
this pull request
Aug 28, 2023
Move the `graph_support_level` enum from `sycl::ext::oneapi::experimental::info` to `sycl::ext::oneapi::experimental` Reflects changes from specification PR #311
Bensuo
approved these changes
Aug 28, 2023
EwanC
pushed a commit
that referenced
this pull request
Aug 28, 2023
Implements spec feedback to remove this property, goes with spec PR #311
EwanC
pushed a commit
that referenced
this pull request
Aug 28, 2023
* [SYCL][Graph] Move `graph_support_level` namespace Move the `graph_support_level` enum from `sycl::ext::oneapi::experimental::info` to `sycl::ext::oneapi::experimental` Reflects changes from specification PR #311 * Give explicit values to enum class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed Greg's most recent feedback points: