[SYCL][Graph] Enable empty nodes in Subgraphs #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation uses the list of scheduled nodes to add a subgraph to a main graph. However, since empty nodes are not scheduled, empty nodes were not listed in this list, resulting in inconsistent graphs when subgraph with empty node(s) were added to a main graph. This PR fixes this issue by forcing to list empty nodes when creating the list for inserting subgraph. It also adds unitests to check that subgraphs with empty nodes are correctly added to a main graph.
mfrancepillois
added
Graph Implementation
EwanC
reviewed
Aug 16, 2023
Changes the definition of MSchedule as it now contains all types of nodes (including empty nodes). Empty nodes are now filtered out when creating the commandbuffer and/or enqueuing nodes to only keep their dependencies. This PR updates a few unitests to make them compliant to the new schedule list definition.
EwanC
approved these changes
Aug 16, 2023
Bensuo
approved these changes
Aug 16, 2023
Co-authored-by: Ben Tracy <[email protected]>
EwanC
pushed a commit
that referenced
this pull request
Aug 16, 2023
* [SYCL][Graph] Enable empty nodes in Subgraphs The implementation uses the list of scheduled nodes to add a subgraph to a main graph. However, since empty nodes are not scheduled, empty nodes were not listed in this list, resulting in inconsistent graphs when subgraph with empty node(s) were added to a main graph. This PR fixes this issue by forcing to list empty nodes when creating the list for inserting subgraph. It also adds unitests to check that subgraphs with empty nodes are correctly added to a main graph. * [SYCL][Graph] Enable empty nodes in Subgraphs Changes the definition of MSchedule as it now contains all types of nodes (including empty nodes). Empty nodes are now filtered out when creating the commandbuffer and/or enqueuing nodes to only keep their dependencies. This PR updates a few unitests to make them compliant to the new schedule list definition. * Update sycl/source/detail/graph_impl.cpp Co-authored-by: Ben Tracy <[email protected]> --------- Co-authored-by: Ben Tracy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation uses the list of scheduled nodes to add a subgraph to a main graph.
However, since empty nodes are not scheduled, empty nodes were not listed in this list, resulting in inconsistent graphs when subgraph with empty node(s) were added to a main graph.
Edit:
This PR changes the definition of MSchedule (schedule list) as it now contains all types of nodes (including empty nodes).
Empty nodes are now filtered out when creating the commandbuffer and/or enqueuing nodes to only keep their dependencies.
This PR updates a few unitests to make them compliant to the new schedule list definition