[SYCL][Graph] Throw exception when calling profiling #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrancepillois
added
Graph Implementation
mfrancepillois
force-pushed
the
maxime/exception_profiling_event
branch
2 times, most recently
from
da0503b to
4763e0f
Compare
reble
approved these changes
Aug 10, 2023
Bensuo
approved these changes
Aug 10, 2023
julianmi
approved these changes
Aug 10, 2023
mfrancepillois
force-pushed
the
maxime/exception_profiling_event
branch
from
4763e0f to
c22823d
Compare
Throws an invalid exception when calling `event::get_profiling_info()` on an event returned by a graph submission. Adds unitests checking that exceptions are throws if `event::get_profiling_info()` is called on an event returned from a queue in recording mode or an event returned by a graph submission.
mfrancepillois
force-pushed
the
maxime/exception_profiling_event
branch
from
c22823d to
06cc9ba
Compare
EwanC
pushed a commit
that referenced
this pull request
Aug 11, 2023
Throws an invalid exception when calling `event::get_profiling_info()` on an event returned by a graph submission. Adds unitests checking that exceptions are throws if `event::get_profiling_info()` is called on an event returned from a queue in recording mode or an event returned by a graph submission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws an invalid exception when calling
event::get_profiling_info()on an event returned by a graph submission.Adds unitests checking that exceptions are throws if
event::get_profiling_info()is called on an event returned from a queue in recording mode or an event returned by a graph submission.