[SYCL][Graph] Duplicate sub-graph nodes #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrancepillois
added
Graph Implementation
EwanC
reviewed
Aug 8, 2023
EwanC
approved these changes
Aug 9, 2023
Bensuo
reviewed
Aug 10, 2023
mfrancepillois
force-pushed
the
maxime/duplicate_sub-graph_nodes
branch
from
ffb5417 to
3327567
Compare
Bensuo
approved these changes
Aug 11, 2023
Collaborator
Bensuo
left a comment
Bensuo
left a comment
There was a problem hiding this comment.
LGTM, just some minor comments.
added 6 commits
August 14, 2023 10:11
Duplicates the nodes of a sub-graph when added to its parents to enable multiple parents. As a result nodes of the initial sub-graph and the one of the main graph are no longer the exact same (shared_pointer) but two different nodes with similar content. A few unitests have been updated accordingly and an equal operator has been added to node_impl to ease comparison between nodes.
Code factorization. Function renaming. Removes the duplication of in-recording queue when duplicating graphs.
Changes the duplication strategy for subgraph. Duplication is now based on scheduled node list.
Removes graph_impl copy constructor
Corrects typos
Rebase fixes + function/code refactorization
mfrancepillois
force-pushed
the
maxime/duplicate_sub-graph_nodes
branch
from
20715ba to
82f2c31
Compare
EwanC
pushed a commit
that referenced
this pull request
Aug 15, 2023
* [SYCL][Graph] Duplicate sub-graph nodes Duplicates the nodes of a sub-graph when added to its parents to enable multiple parents. As a result nodes of the initial sub-graph and the one of the main graph are no longer the exact same (shared_pointer) but two different nodes with similar content. A few unitests have been updated accordingly and an equal operator has been added to node_impl to ease comparison between nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicates the nodes of a sub-graph when added to its parents to enable multiple parents.
As a result nodes of the initial sub-graph and the one of the main graph are no longer the exact same (shared_pointer) but two different nodes with similar content.
A few unitests have been updated accordingly and an equal operator has been added to node_impl to ease comparison between nodes.