[SYCL][Graph] Throw exception when creating graph for unsupported backend #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kend Checks backend when creating graphs and throws an exception is the backend is not supported. Adds an e2e test to verify this exception throwing. Adapts Unitests to pass through the backend exception even if backends are not available for Unitests by forcing emulation mode.
mfrancepillois
added
the
Graph Implementation
reble
changed the title
reble
reviewed
Jul 31, 2023
reble
reviewed
Aug 1, 2023
reble
reviewed
Aug 1, 2023
Co-authored-by: Pablo Reble <[email protected]>
Co-authored-by: Pablo Reble <[email protected]>
EwanC
reviewed
Aug 1, 2023
…kend Corrects clang format + typo
julianmi
approved these changes
Aug 2, 2023
Collaborator
julianmi
left a comment
julianmi
left a comment
There was a problem hiding this comment.
LGTM. I have only minor comments.
Co-authored-by: Julian Miller <[email protected]>
Bensuo
reviewed
Aug 3, 2023
…kend Adds function helper to force emulated backend in Unitests. Updates some comments
…kend Improves mock usage in Unitest to avoid having to force emulation mode
mfrancepillois
pushed a commit
that referenced
this pull request
Aug 9, 2023
…kend (#280) * [SYCL][Graph] Throw exception when creating graph for unsupported backend - Checks backend when creating graphs and throws an exception is the backend is not supported. - Adds an e2e test to verify this exception throwing. - Updates some comments - Improves mock usage in Unitest to avoid having to force emulation mode --------- Co-authored-by: Pablo Reble <[email protected]> Co-authored-by: Julian Miller <[email protected]>
EwanC
pushed a commit
that referenced
this pull request
Aug 10, 2023
…kend (#280) * [SYCL][Graph] Throw exception when creating graph for unsupported backend - Checks backend when creating graphs and throws an exception is the backend is not supported. - Adds an e2e test to verify this exception throwing. - Updates some comments - Improves mock usage in Unitest to avoid having to force emulation mode --------- Co-authored-by: Pablo Reble <[email protected]> Co-authored-by: Julian Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks backend when creating graphs and
throws an exception is the backend is not supported. Adds an e2e test to verify this exception throwing. Adapts Unitests to pass through the backend exception even if backends are not available for Unitests
by forcing emulation mode.