Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera pan while dragging node bug #248

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented May 30, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

If you drag the camera and then quickly drag a node, both actions happen simultaneously

What is the new behavior?

You can't drag the camera and a node simultaneously

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

BEFORE

Screen.Recording.2024-05-30.at.4.41.51.PM.mov

AFTER

Screen.Recording.2024-05-30.at.4.41.06.PM.mov

@ghsteff ghsteff requested a review from amcdnl May 30, 2024 21:43
Copy link

netlify bot commented May 30, 2024

Deploy Preview for reagraph failed. Why did it fail? →

Name Link
🔨 Latest commit d3c7cc5
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/6658f3008430880008d82e26

@amcdnl amcdnl merged commit 569be65 into master May 31, 2024
1 of 5 checks passed
@amcdnl amcdnl deleted the fix/node-drag-camera-pan-bug branch May 31, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants