feat: update statement column lineage (#487) #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoxingda
force-pushed
the
feat/update-stmt-col-lineage
branch
from
235549f to
e9f05e5
Compare
maoxingda
force-pushed
the
feat/update-stmt-col-lineage
branch
from
e9f05e5 to
2ec1af2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 41 41
Lines 2185 2191 +6
=======================================
+ Hits 2174 2180 +6
Misses 11 11 ☔ View full report in Codecov by Sentry. |
|
I would like to ask for advice on how to solve codecov check failed? |
reata
requested changes
Jan 2, 2024
There was a problem hiding this comment.
For update statement, we don't have to duplicate a lot of methods in SelectExtractor, it's more like merge statement. Please refer to MergeExtractor.
maoxingda
force-pushed
the
feat/update-stmt-col-lineage
branch
from
db7911d to
aeeda08
Compare
reata
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #487