-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lateral column alias reference (#507) #521
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 41 41
Lines 2170 2185 +15
=======================================
+ Hits 2159 2174 +15
Misses 11 11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. The code looks good to me.
One question: can we extend the current logic to handle lateral column alias at top level (not in a subquery), or do you plan to handle that in separate PR?
insert into public.tgt_tbl1
select
name as user_name,
user_name as id -- backward reference
from
public.src_tbl1
;
Thanks for response. I'm not sure if I can handle it, but I'll give it a try. |
We can also merge this and not closing #507, if top-level lateral column alias takes too much effort. Just let me know your conclusion. Thanks for taking time investigating. |
If it can be like this, that would be the best. |
I will try to expand at top level. |
f0efc8a
to
3cf66c2
Compare
It seems that it doesn't require too much effort. |
Closes #507