Skip to content

fix: cte inside bracketed of insert #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 24, 2023
Merged

Conversation

duongphannamhung
Copy link
Contributor

re-fix issue: #377

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #395 (701c80a) into master (52f3b75) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files          42       42           
  Lines        2008     2013    +5     
=======================================
+ Hits         1996     2001    +5     
  Misses         12       12           
Impacted Files Coverage Δ
...parser/sqlfluff/extractors/dml_insert_extractor.py 100.00% <100.00%> (ø)

@reata
Copy link
Owner

reata commented Jun 24, 2023

I have removed the is_cte function as it doesn't seem that we can reuse it. Also the test case is moved to test_sqlfluff.py, which contains all the new features we don't/won't support in sqlparse. Other than that, this PR is perfect fine.

@reata reata merged commit 2f78788 into reata:master Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants