-
Notifications
You must be signed in to change notification settings - Fork 247
Fix merge queries #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix merge queries #375
Conversation
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
=======================================
Coverage 99.39% 99.39%
=======================================
Files 42 42
Lines 1975 1981 +6
=======================================
+ Hits 1963 1969 +6
Misses 12 12
|
I'll review this code tomorrow. Thanks for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the full picture regarding what feature in MERGE statement is ANSI compatible and what's not. Can you help take a look? Rule of thumb, if it's ANSI compatible, move the test case to test_others.py. If not, list all the supported dialect for each test case. And add some comment on what feature makes each test case dialect specific.
In case merge queries for bigquery following are the cases that needs to be handled:
INTO
keyword afterMERGE
is optionalINSERT
are optional for exampleINSERT VALUES (actual...values)
USING
keyword can be a CTE query (this is not specific to bigquery)part of fix for open-metadata/OpenMetadata#7427 ref1 ref2
Closes #380