Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLLineageConfig boolean value returns True for all non-empty strings #551

Closed
maoxingda opened this issue Jan 14, 2024 · 0 comments · Fixed by #552
Closed

SQLLineageConfig boolean value returns True for all non-empty strings #551

maoxingda opened this issue Jan 14, 2024 · 0 comments · Fixed by #552
Labels
bug Something isn't working

Comments

@maoxingda
Copy link
Contributor

SQLLineageConfig returns True for all non-empty strings

Expected

'true', 'on', 'ok', 'y', 'yes', '1'

For the strings in the above list, return True, otherwise return False
@maoxingda maoxingda added the bug Something isn't working label Jan 14, 2024
maoxingda added a commit to maoxingda/sqllineage that referenced this issue Jan 14, 2024
@maoxingda
fix: SQLLineageConfig returns True for all non-empty strings (reata#551)
fc89355
@maoxingda maoxingda mentioned this issue Jan 14, 2024
Merged
@reata reata changed the title SQLLineageConfig returns True for all non-empty strings SQLLineageConfig boolean value returns True for all non-empty strings Jan 14, 2024
reata added a commit that referenced this issue Jan 14, 2024
@maoxingda @reata
fix: SQLLineageConfig boolean value returns True for all non-empty st…
06a474b 
…rings (#552)

* fix: SQLLineageConfig returns True for all non-empty strings (#551)

* add test_config_parse_value_with_cast_none test case

* refactor: remove redundant logic

---------

Co-authored-by: reata <[email protected]>
delphisharp pushed a commit to delphisharp/sqllineage that referenced this issue Jan 14, 2024
@maoxingda @reata
fix: SQLLineageConfig boolean value returns True for all non-empty st…
255060d 
…rings (reata#552)

* fix: SQLLineageConfig returns True for all non-empty strings (reata#551)

* add test_config_parse_value_with_cast_none test case

* refactor: remove redundant logic

---------

Co-authored-by: reata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@maoxingda