Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reerror: error-resilient parsing (same as Merlin for OCaml) #2439

Closed
wants to merge 46 commits into from
Closed

Reerror: error-resilient parsing (same as Merlin for OCaml) #2439

wants to merge 46 commits into from

Conversation

let-def
Copy link
Contributor

@let-def let-def commented Aug 9, 2019

This PR implements a new "parsing loop" that is more robust to errors and should improve the experience in an IDE.

The parser itself is not affected (we still have a declarative grammar), but we now have a slightly different interpretation in interactive use-cases.

@let-def
Copy link
Contributor Author

let-def commented Aug 9, 2019

Esy is missing the "fix" dependency. I don't know the proper way to update it.

@ulrikstrid
Copy link
Contributor

I can add @opam/fix via a resolution in a package.json. I wonder if this is a bug with parsing the .opam file in esy.

cc @andreypopp

@jordwalke
Copy link
Member

Been testing this out and it's so good.
@ulrikstrid - it wouldn't be a resolution, it would just be a regular dependency.

@let-def you just add "@opam/fix": "*" to the "dependencies" section of src/refmt/esy.json and ./esy.json (the later is just the development-time package configuration, the later is what will be released).

If you just add those fields, the CI should pass and we can release this puppy.

@@ -0,0 +1,18 @@
Recovery (Urgent):
Copy link
Member

@jordwalke jordwalke Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to delete this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@jordwalke
Copy link
Member

Woohoo! Closing now that it's merged (after @anmonteiro rebased it). Very excited to announce this one.

@jordwalke jordwalke closed this Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants