-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reerror: error-resilient parsing (same as Merlin for OCaml) #2439
Conversation
Modules are being namespaced, direct access is now deprecated and will be removed (at some unknown point in the future).
Still broken, the analysis can be improved
Recovery generates empty closing tag
Fix build with all versions of OCaml
Esy is missing the "fix" dependency. I don't know the proper way to update it. |
I can add cc @andreypopp |
Been testing this out and it's so good. @let-def you just add If you just add those fields, the CI should pass and we can release this puppy. |
@@ -0,0 +1,18 @@ | |||
Recovery (Urgent): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to delete this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Woohoo! Closing now that it's merged (after @anmonteiro rebased it). Very excited to announce this one. |
This PR implements a new "parsing loop" that is more robust to errors and should improve the experience in an IDE.
The parser itself is not affected (we still have a declarative grammar), but we now have a slightly different interpretation in interactive use-cases.