New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declaring type name upper case blows up the editor #1691

Closed

xixixao opened this issue Dec 8, 2017 · 0 comments

Contributor

xixixao commented Dec 8, 2017

https://reasonml.github.io/try/?reason=FAFwngDgpgBAGjAvMGMA+MASUA2OD2K6MAQjgIYBGFA3MEA

chenglou added a commit to chenglou/reason that referenced this issue


          Not throw Location.Error in the parser

aebe9cb

Fixes reasonml#1691

This is because our public API says we only ever throw Syntaxerr.Error or Syntax_utils.Error. This caused https://github.com/facebook/reason/blob/731e605870e22fdcb3d37f3f963d346f18a072cc/bspacks/refmtJsApi.ml#L49 not to catch the extra Location.Error correctly and failing to massage the data structure before using it in the browser.

chenglou mentioned this issue

Not throw Location.Error in the parser #1695

Merged

chenglou added a commit to chenglou/reason that referenced this issue


          Not throw Location.Error in the parser

3e35240

Fixes reasonml#1691

This is because our public API says we only ever throw Syntaxerr.Error or Syntax_utils.Error. This caused https://github.com/facebook/reason/blob/731e605870e22fdcb3d37f3f963d346f18a072cc/bspacks/refmtJsApi.ml#L49 not to catch the extra Location.Error correctly and failing to massage the data structure before using it in the browser.

chenglou added a commit to chenglou/reason that referenced this issue


          Not throw Location.Error in the parser

84aa6ba

Fixes reasonml#1691

This is because our public API says we only ever throw Syntaxerr.Error or Syntax_utils.Error. This caused https://github.com/facebook/reason/blob/731e605870e22fdcb3d37f3f963d346f18a072cc/bspacks/refmtJsApi.ml#L49 not to catch the extra Location.Error correctly and failing to massage the data structure before using it in the browser.

chenglou closed this as completed in #1695

chenglou added a commit that referenced this issue


          Not throw Location.Error in the parser (#1695)

0e5e83f

* Not throw Location.Error in the parser

Fixes #1691

This is because our public API says we only ever throw Syntaxerr.Error or Syntax_utils.Error. This caused https://github.com/facebook/reason/blob/731e605870e22fdcb3d37f3f963d346f18a072cc/bspacks/refmtJsApi.ml#L49 not to catch the extra Location.Error correctly and failing to massage the data structure before using it in the browser.

* Document it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment