Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard time parsing (curNode^)##childNodes and wrong refmt #1554

Closed
bsansouci opened this issue Oct 27, 2017 · 1 comment · Fixed by #2044
Closed

Hard time parsing (curNode^)##childNodes and wrong refmt #1554

bsansouci opened this issue Oct 27, 2017 · 1 comment · Fixed by #2044
Labels
KIND: BUG Parser parsing reason code into an AST

Comments

@bsansouci
Copy link
Contributor

It seems like curNode^##childNodes isn't valid, so I thought of using parens which works but causes refmt to barf:

(curNode^)##childNodes

turns into

curNode^##childNodes

which gives the error:
screen shot 2017-10-26 at 23 10 25

and then gets turned into

curNode ^## childNodes
@chenglou chenglou mentioned this issue Oct 30, 2017
Closed
11 tasks
@chenglou chenglou mentioned this issue Nov 22, 2017
Closed
16 tasks
@nireno
Copy link

nireno commented Jun 8, 2018

I get a similar issue with (obj##xs)[0] being refmt'd to obj##xs[0]. With the parentheses removed I get this error: Error: Js object ## expect syntax like obj##(paint (a,b)).

@jaredly jaredly added KIND: FEATURE REQUEST Parser parsing reason code into an AST KIND: BUG and removed KIND: FEATURE REQUEST labels Jun 14, 2018
anmonteiro added a commit to anmonteiro/reason that referenced this issue Jul 2, 2018
@anmonteiro
Print (foo^)##bar with the right precedence
051ad60 
fixes reasonml#1554
@anmonteiro anmonteiro mentioned this issue Jul 2, 2018
Merged
chenglou pushed a commit that referenced this issue Jul 4, 2018
@anmonteiro @chenglou
Print (foo^)##bar with the right precedence (#2044)
6faf401 
* Print (foo^)##bar with the right precedence

fixes #1554

* code review tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
KIND: BUG Parser parsing reason code into an AST
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Print (foo^)##bar with the right precedence anmonteiro/reason
3 participants
@jaredly @nireno @bsansouci