-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing primitives in rely with JSOO #207
Comments
…ply to be prefixed by unstable to reflect their currently experimental nature (#208) Summary: We need to release a new version of Pastel for JSOO compatibility (#207). This should ideally have been done when the usage of Str was removed in favor of Re Pull Request resolved: #208 Differential Revision: D18341628 Pulled By: bandersongit fbshipit-source-id: 05fb76a8aa19a7d7234d4f9bbf54be33d5bbe351
@Et7f3 A new version of Pastel has been released. I'll spend some time in the next couple days making it so that snapshots don't cause these errors if they aren't being used. |
I filed ocsigen/js_of_ocaml#913 to add unix_is_atty to JSOO along with my thoughts on implementation. I've verified that your example now works if you provide a manual stub for unix_isatty, use the latest version of Pastel, and create a snapshot directory. |
I'm blind I don't see where you fix str issue 👀. |
Hy I wanted to update https://github.com/bryphe/reason-gl-matrix to rely. I was able to convert to rely natively but I can't run when building with JSOO.
I have some repro on my fork on branch Et7f3/test/switch_to_rely or commit instead Et7f3/reason-gl-matrix@ec2fd9d
I quote some message from discord (https://ptb.discordapp.com/channels/235176658175262720/469417973820686336/641021659989540925).
Me:
@bandersongit
Me:
@bandersongit
The text was updated successfully, but these errors were encountered: