Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable toplevel exit #384

Closed
wants to merge 7 commits into from
Closed

Portable toplevel exit #384

wants to merge 7 commits into from

Commits on Jul 8, 2022

  1. Report exits from the toplevel correctly

    Previously, you just got:
    
        ocaml-mdx-test: internal error, uncaught exception:
                        Compenv.Exit_with_status(125)
    talex5 committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    5d1167e View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Configuration menu
    Copy the full SHA
    df4e3cc View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Patch and redirect available directives

    They have to be redirected because by default they write to stdout, but
    we capture stderr (and in 4.14 they write to stderr). Unfortunately,
    just overwriting them in the directives Hashtbl does not work, since
    the ordering of additions is somewhat undefined so they might be
    overwritten. A safer way is to create new directives and rewrite those
    to be evaluated to them.
    
    Also, `"use"` is a builtin directive, not from findlib so needs to be
    excluded to get the error message printed.
    Leonidas-from-XIV committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    19095a9 View commit details
    Browse the repository at this point in the history
  2. Fix redirection for older and newer versions

    `use_output` was added in 4.11, whereas the `use_trace` was removed in
    4.13.
    Leonidas-from-XIV committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    cfedb20 View commit details
    Browse the repository at this point in the history
  3. Redefine the directives to throw an error on failure

    The stdlib pre-4.14 defines them to be `ignore`d but they can be made to
    throw the error like in 4.14. At least some of them, for which the
    underlying functions are exposed in the interface.
    Leonidas-from-XIV committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    6fd673c View commit details
    Browse the repository at this point in the history
  4. Add support for load_rec and patch load conditionally

    OCaml 4.13 introduces a few deprecations that we need to work around.
    Leonidas-from-XIV committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    c520c0a View commit details
    Browse the repository at this point in the history
  5. Add changelog entry

    Leonidas-from-XIV committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    d783566 View commit details
    Browse the repository at this point in the history