Improve testing text #3447
Merged
Improve testing text #3447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsm
reviewed
Aug 26, 2021
| match Queue.peek t.events with | ||
| | None -> () | ||
| | Some time -> | ||
| if Time_ns.Span.( >= ) (Time_ns.diff t.now time) t.period |
There was a problem hiding this comment.
This is a little hard to read. Perhaps break up into two lines?
let diff = Time_ns.diff t.now time in
if Time_ns.Span.(diff >= t.period)
There was a problem hiding this comment.
I don't like the proposed style because it opens up Span and it's unclear what identifiers might be shadowed in such expressions.
Really, we need modular implicits to make this kind of code nice! (And Flambda, to make it fast again.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.