refactor(analytics): GA analytics tracker from ENV variable #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lytics logic into background pa Based on process.env.NODE_ENV either GA_TRACKER_DEV or GA_TRACKER_PROD is loaded from .evn file. Also moved the analytics from template appending mechanism to background page because of clashes with host site GA. More details in SO answer https://stackoverflow.com/questions/10285886/chrome-extension-adding-external-javascript-to-current-pages-html?answertab=active#tab-top Closes realreality#52
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
- Coverage 15.25% 15.08% -0.18%
==========================================
Files 14 14
Lines 354 358 +4
Branches 53 53
==========================================
Hits 54 54
- Misses 284 288 +4
Partials 16 16
Continue to review full report at Codecov.
|
vire
force-pushed
the
externalize-analytics-usage
branch
from
45904bd to
dfb7d25
Compare
Added $track instance method to enable passing event to background page for pushing to analytics
vire
force-pushed
the
externalize-analytics-usage
branch
from
dfb7d25 to
c03fdc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move analytics logic into background page
Based on process.env.NODE_ENV either GA_TRACKER_DEV or GA_TRACKER_PROD is loaded from .evn file.
Also moved the analytics from template appending mechanism to background page because of clashes
with host site GA. More details in SO answer
https://stackoverflow.com/questions/10285886/chrome-extension-adding-external-javascript-to-current-pages-html?answertab=active#tab-top
Closes #52