Delay fStreamListMutex initialization
#33
Conversation
`std::optional` fallback to `std::experimental::optional` for older compilers.
Initializes the mutex on `init` and reports errors in the same way as we do for all other errors (via `SDL_GetError()`). This also eliminates the only use of exceptions in SDL_audiolib.
|
Sorry, no :P Locking is not optional. If a lock cannot be acquired, the application should shut down since something is seriously broken. The exception that is thrown simply gives applications the opportunity to do a more graceful shutdown. It's not a condition that can just be logged and then have execution resumed. On systems where you build without exceptions, I think it should probably just terminate. Let's go back to #32 and simply sort it out there. |
|
The mutex is initialized statically, the application has no chance to catch this exception at all even if exceptions are enabled. Perhaps just replace with |
|
Closing in favor of #32. |
Thanks for pointing that out. I'll need to change it. |
Initializes the mutex on
initand reports errors in the same way as we do for all other errors (viaSDL_GetError()).This also eliminates the only use of exceptions in SDL_audiolib.