-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible Sync V2 (Proposed 1) #7755
Open
dianaafanador3
wants to merge
3
commits into
master
Choose a base branch
from
dp/flx_sync_v2_1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2430945
to
1fe61ab
Compare
b50f9dc
to
5b4e0a0
Compare
leemaguire
reviewed
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach this is taking. I'll play around with a sync app to test out the SwiftUI property wrappers.
leemaguire
reviewed
May 18, 2022
leemaguire
reviewed
May 18, 2022
32dd8ad
to
67340af
Compare
67340af
to
2e4964a
Compare
2e4964a
to
65bd7eb
Compare
a2757f3
to
a6f6bc7
Compare
@dianaafanador3 is this PR something we still want to move forward with? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a complete new API for Flexible Sync, intended to make flexible sync less confusing to the developer.
SwiftUI
You can use
@ObservedResults
to add a subscription and retrieve data from itWe are adding a new property to
@ObservedResults
which includes a state value, this state will publish any subscription state changes to view.Notes