Expose a block to determine if the Realm should be compacted on launch #4755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsim
force-pushed
the
jp-compact-on-launch
branch
from
900634c to
a1cd4ae
Compare
jpsim
force-pushed
the
jp-compact-on-launch
branch
from
a1cd4ae to
8415d8a
Compare
jpsim
force-pushed
the
jp-compact-on-launch
branch
from
8415d8a to
2a7ca93
Compare
jpsim
force-pushed
the
jp-compact-on-launch
branch
from
c6bac68 to
418470c
Compare
jpsim
force-pushed
the
jp-compact-on-launch
branch
from
418470c to
eae469b
Compare
jpsim
changed the title
|
This is now ready for review. |
tgoyne
approved these changes
Apr 17, 2017
|
|
||
| - (void)testCompactOnLaunchCannotBeSet { | ||
| // This test just needs a single process, so skip child. | ||
| if (!self.isParent) { return; } |
There was a problem hiding this comment.
The child process is created by RLMRunChildAndWait(), so there's no need to do anything other than just not call that if only one process is needed.
Realm/RLMRealmConfiguration.mm
Outdated
| @@ -275,4 +279,21 @@ - (NSString *)pathOnDisk { | |||
| return @(_config.path.c_str()); | |||
| } | |||
|
|
|||
| - (void)setShouldCompactOnLaunch:(RLMShouldCompactOnLaunchBlock)shouldCompactOnLaunch { | |||
| _shouldCompactOnLaunch = shouldCompactOnLaunch; | |||
There was a problem hiding this comment.
Should set this after validation so that the object isn't left in an inconsistent state when validation fails.
to prevent the configuration from being left in an inconsistent state
austinzheng
approved these changes
Apr 17, 2017
| @@ -0,0 +1,86 @@ | |||
| //////////////////////////////////////////////////////////////////////////// | |||
| // | |||
| // Copyright 2015 Realm Inc. | |||
This was referenced Apr 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3289.