[iOS] Support RN 0.46+, #1121 #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I wrap code by |
ovr
force-pushed
the
patch-1
branch
2 times, most recently
from
a7028d3 to
7161472
Compare
|
Tested the fix and it works for me. thank you @ovr |
|
Thanks @ovr! |
This was referenced Jul 6, 2017
fealebenpae
added a commit
that referenced
this pull request
Jul 6, 2017
|
@fealebenpae can please you tell me when you'll release this? I tried referencing your commit in my packager but then it doesn't pull through the GCDWebServer submodule and I get this build error when I run my project with Xcode. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Issue: #1121
Small PR that helps us to support RN 0.46+
Thank