Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sync + fix encryption race #6647

Merged
merged 6 commits into from
Nov 5, 2019

Conversation

cmelchior
Copy link
Contributor

@cmelchior cmelchior commented Oct 29, 2019

Closes #5668
Closes #6093
Closes #6152
Closes #6239
Closes #6257
Closes #6505
Closes #6362
Closes #6634
Closes #6525

TODO

  • Fix changelog.
  • Find other open issues that are caused by this.

@cmelchior cmelchior self-assigned this Oct 29, 2019
@mehulsutariya
Copy link

Hi @cmelchior,

A bunch of issues related to native crashes while using encryption are referenced in this merge request.

Can you elaborate on what is the issue and how will this help fix it. We can help out with testing it locally at our end if needed.

@bmunkholm
Copy link
Contributor

bmunkholm commented Oct 30, 2019

@mehulsutariya
You can see the details of the core issues and PR here. But it basically fixes one rootcause of corruption of encrypted files on Android specifically. Or it at least fixes some rootcauses for it. We are still investigating another potential race to see if that could be another cause of corruption and are therefore waiting on releasing this until that has been clarified during this week.
Do you have reproducible corruption cases using encryption? In that case it would be great if you can validate that it indeed fixes it. @cmelchior could provide a snapshot version perhaps?

Perhaps @vladimirfx would be able to validate as well?

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mehulsutariya
Copy link

Thanks for the details. We would be able to test it locally at our end on specific devices. If you can provide snapshot, that would help.

It would be awesome if it indeed fixes this issue as we are getting 1000s of such crashes on daily basis and looking at other issues in this project, many other users are facing this for a while now.

@cmelchior cmelchior requested a review from nhachicha October 30, 2019 14:02
@cmelchior cmelchior marked this pull request as ready for review October 30, 2019 14:03
@cmelchior cmelchior merged commit 0c80dfc into releases Nov 5, 2019
@cmelchior cmelchior deleted the cm/bug/encryption-bug-upgrade-sync branch November 5, 2019 10:34
@mehulsutariya
Copy link

mehulsutariya commented Nov 21, 2019

@cmelchior @bmunkholm We are still seeing the following crash after updating to snapshot version. Should I file a separate issue for this?

  #00  pc 00000000000c0f38  /data/app/<redacted>-kHD68b8V8irGP4n5OAvkIg==/lib/arm64/librealm-jni.so
  #01  pc 0000000000167c94  /data/app/<redacted>-kHD68b8V8irGP4n5OAvkIg==/lib/arm64/librealm-jni.so
  #02  pc 000000000015587c  /data/app/<redacted>-kHD68b8V8irGP4n5OAvkIg==/lib/arm64/librealm-jni.so (Java_io_realm_internal_UncheckedRow_nativeGetString+92)
  #03  pc 000000000017effc  /data/app/<redacted>-kHD68b8V8irGP4n5OAvkIg==/oat/arm64/base.odex (io.realm.internal.Table.nativeGetColumnName [DEDUPED]+140)
  #04  pc 00000000000059e4  /dev/ashmem/dalvik-jit-code-cache (deleted)

You can see the Crash Distribution by Device in the below screenshot. As previously shared in a related issue, Samsung dominates this issue more than any other device.

Screenshot 2019-11-21 at 2 59 02 PM

@bmunkholm
Copy link
Contributor

bmunkholm commented Nov 21, 2019

@mehulsutariya Yes please post a new issue with the complete crash info.
Thanks!

@bmunkholm
Copy link
Contributor

Also, please use the released version. Snapshot version is undefined. We don't know which specific version you have used.

@mehulsutariya
Copy link

We are using 6.1.0-SNAPSHOT

@bmunkholm
Copy link
Contributor

A SNAPSHOT version can change - depending on when you take it. So it's never a well defined version.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants