fix/iOS: Load realm-wrapper DLL using MainBundle.PrivateFrameworksPath#3714
fix/iOS: Load realm-wrapper DLL using MainBundle.PrivateFrameworksPath#3714EmilienDup wants to merge 1 commit intorealm:mainfrom
Conversation
|
Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @EmilienDup. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a |
|
@EmilienDup can you please rebase this work on the |
|
On the I can probably add it, but as Another solution could be to add - <TargetFrameworks>netstandard2.0;net6.0;net8.0</TargetFrameworks>
+ <TargetFrameworks>netstandard2.0;net6.0;net8.0;net8.0-ios</TargetFrameworks>But there might be a good reason why |
|
Oh... that's a good point. Yeah, I think adding platform-specific TFMs can open a can of worms we don't want to open right now 😬 Without major rework, I think our best path forward is probably the reflection change you proposed in #3711 (comment). My only suggestion there is to use a runtime check instead of a preprocessor directive since that will not work when the binary is built against an earlier .NET version. I.e. instead of |
|
Yeah, the reflection change seems to be the easiest change for now. I will probably open a new PR targeting the |
|
Closing in favor of #3718 |
Description
Fixes #3711.
Allows Realm to work in net10-ios apps.
This change is minimal.
It is based on this comment.
Ideally I think it would have been better to delegate the wrappers initialization to the platform level (Windows & iOS).
But as the platform level code is not part of the main assembly, changing the resolver of another assembly is not recommended.
As I am developing on a Mac, I encountered a lot of hiccups when trying to build the various projects.
Based on my testings it should work fine on net8-ios and net10-ios, but if it is possible to generate nuget packages from my PR, I would like to test them in a standalone app to make sure everything works well once packaged up.
TODO