Skip to content

RDART-930: Refactor handles #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nielsenko merged 68 commits into from
May 27, 2024
Merged

RDART-930: Refactor handles #1550

nielsenko merged 68 commits into from
May 27, 2024

Conversation

@nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Mar 11, 2024 •
edited
Loading

Split and refactoring complete.

   wc -l file
       2 ./convert_native.dart
       4 ./ffi.dart
      22 ./query_handle.dart
      22 ./scheduler_handle.dart
      24 ./convert.dart
      24 ./realm_library.dart
      28 ./subscription_handle.dart
      35 ./notification_token_handle.dart
      55 ./map_changes_handle.dart
      70 ./error_handling.dart
      78 ./collection_changes_handle.dart
      80 ./async_open_task_handle.dart
      81 ./subscription_set_handle.dart
      82 ./credentials_handle.dart
      85 ./rooted_handle.dart
      90 ./mutable_subscription_set_handle.dart
      90 ./schema_handle.dart
      93 ./handle_base.dart
     117 ./results_handle.dart
     132 ./set_handle.dart
     142 ./decimal128.dart
     146 ./list_handle.dart
     164 ./session_handle.dart
     172 ./to_native.dart
     191 ./realm_core.dart
     200 ./map_handle.dart
     207 ./object_handle.dart
     268 ./config_handle.dart
     354 ./user_handle.dart
     358 ./from_native.dart
     461 ./realm_handle.dart
     592 ./app_handle.dart
   13407 ./realm_bindings.dart

Fixes: #1479

@cla-bot cla-bot bot added the cla: yes label Mar 11, 2024
@nielsenko nielsenko changed the base branch from main to kn/xcode-15 March 11, 2024 20:12
@nielsenko nielsenko force-pushed the kn/refactor-handles-2 branch 2 times, most recently from d34879b to 2e43af9 Compare March 11, 2024 20:55
@nielsenko nielsenko force-pushed the kn/refactor-handles-2 branch 3 times, most recently from 921d00f to aaf0823 Compare March 22, 2024 16:40
@nielsenko nielsenko changed the base branch from kn/xcode-15 to main March 22, 2024 16:44
@nielsenko nielsenko force-pushed the kn/refactor-handles-2 branch from fe4e105 to 697f5c1 Compare April 12, 2024 10:23
@coveralls-official
Copy link

coveralls-official bot commented Apr 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9204660800

Details

  • 2029 of 2205 (92.02%) changed or added relevant lines in 47 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 86.679%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/realm_dart/lib/src/map.dart 21 22 95.45%
packages/realm_dart/lib/src/native/collection_changes_handle.dart 20 21 95.24%
packages/realm_dart/lib/src/native/collection_handle_base.dart 16 17 94.12%
packages/realm_dart/lib/src/native/convert.dart 5 6 83.33%
packages/realm_dart/lib/src/session.dart 10 11 90.91%
packages/realm_dart/lib/src/set.dart 14 15 93.33%
packages/realm_dart/lib/src/credentials.dart 16 18 88.89%
packages/realm_dart/lib/src/native/realm_library.dart 6 8 75.0%
packages/realm_dart/lib/src/native/results_handle.dart 47 49 95.92%
packages/realm_dart/lib/src/realm_object.dart 31 33 93.94%
Files with Coverage Reduction New Missed Lines %
packages/realm_dart/lib/src/subscription.dart 1 90.0%
Totals Coverage Status
Change from base Build 9204562565: 0.1%
Covered Lines: 5889
Relevant Lines: 6794
💛 - Coveralls

@nielsenko nielsenko force-pushed the kn/refactor-handles-2 branch 9 times, most recently from 5f03272 to a8cecc6 Compare April 13, 2024 21:05
@nielsenko nielsenko added the no-changelog Used to skip the changelog check label Apr 15, 2024
@nielsenko nielsenko force-pushed the kn/refactor-handles-2 branch 4 times, most recently from 5ca0803 to bfd85df Compare April 17, 2024 08:29
@nielsenko nielsenko force-pushed the kn/refactor-handles-2 branch 5 times, most recently from 4a1a398 to 342a450 Compare April 24, 2024 14:54
nielsenko added 24 commits May 26, 2024 11:42
@nielsenko
Make a bunch of function public in prep for getting rid of parts
b1ebcc5
@nielsenko
Refactor XChangesHandle
95ff222
@nielsenko
Use CredentialsHandle not Credentils
e3e6788
@nielsenko
Traffic in ResultsHandle not RealmResult + dart fix stuff
62ed52a
@nielsenko
Split part files
cd11777
@nielsenko
Move XTokenHandles
5c62750
@nielsenko
toNative extension method replaces toRealmValue function
0e3acef
@nielsenko
Replace last use of deprecated Pointer.elementAt(i)
082686f
@nielsenko
More RealmHandle stuff
bfefe18
@nielsenko
Replace invokeGetBool and invokeGetPointer
ef67743
@nielsenko
Run melos custom_format
e262b1d
@nielsenko
Move callAppFunction stuff
f311129
@nielsenko
Refactor equals
5c8be2e
@nielsenko
Move raiseIfNull to HandleBase ctor. Rename to be explicit about call…
6af1dd9 
… to getLastError
@nielsenko
Completely unrelated spelling corrections in CHANGELOG
82a0330
@nielsenko
Seperate AsyncOpenTaskHandle and NotificationHandle from realm_core.dart
defc5ae
@nielsenko
moving guardSynchronousCallback and getApp out of realm_core.dart
4e359f3
@nielsenko
Split native convertion functions into separate files
199663e
@nielsenko
Last leg.. for now
90f2e92
@nielsenko
PR feedback
1922252
@nielsenko
Fix rebase
fe9227b
@nielsenko
Tweat memEquals perf test
8ee2b31
@nielsenko
fixup! Last leg.. for now
fe7d582
@nielsenko
Fix after rebase
4e75f51
@nielsenko nielsenko force-pushed the kn/refactor-handles-2 branch from c5b05a2 to 4e75f51 Compare May 26, 2024 10:56
@nielsenko nielsenko merged commit 5e4e6a7 into main May 27, 2024
@nielsenko nielsenko deleted the kn/refactor-handles-2 branch May 27, 2024 10:43
nirinchev added a commit that referenced this pull request May 27, 2024
@nirinchev
Merge branch 'main' into ni/progress-notifications
2d0042a 
* main: (37 commits)
  RDART-930: Refactor handles (#1550)
  Forgot to show GeoPolygon
  Add vNext Changelog header (#1687)
  [Release 2.3.0] (#1686)
  RDART-1028: Use Zone.current.bindUnaryCallbackGuarded for RawReceivePort.handler (#1683)
  RDART-1021: Wire up some basic dynamic setting and change notifications (#1669)
  RDART-1022: Drop x86 as target (#1682)
  RDART-1034: Update realm-core to v14.7.0 (#1681)
  Skip select test
  RDART-1018: Fix badly generated _fromJson (#1664)
  Add vNext Changelog header (#1660)
  [Release 2.2.1] (#1659)
  Update CHANGELOG.md
  RDART-1016: Cleanup iOS podspec (#1658)
  Add vNext Changelog header (#1655)
  [Release 2.2.0] (#1654)
  RDART-1015: Update core to v14.6.2 (#1651)
  RDART-950: Update nullability annotations for base url API (#1652)
  RDART-964: Add PrivacyInfo.xcprivacy for iOS and macOS (#1646)
  RDART-1014: Bump required sdk version to ^3.3.0 (#1648)
  ...

# Conflicts:
#	CHANGELOG.md
#	packages/realm_dart/lib/src/native/realm_core.dart
#	packages/realm_dart/src/realm-core
#	packages/realm_dart/test/realm_test.dart
#	packages/realm_dart/test/session_test.dart
#	packages/realm_dart/test/test.dart
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@papafe papafe papafe approved these changes

@nirinchev nirinchev Awaiting requested review from nirinchev

+1 more reviewer

@elle-j elle-j elle-j approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nielsenko nielsenko

Labels

cla: yes no-changelog Used to skip the changelog check

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-factor realm_core.dart into handle specific files

5 participants

@nielsenko @nirinchev @papafe @elle-j