fix: add missing cstdlib header in cli_args.cpp#8089
Merged
tgoyne merged 1 commit intorealm:masterfrom Dec 15, 2025
Merged
Conversation
Add missing #include <cstdlib> header to provide declaration for std::strtol function used on line 67. This fixes compilation issues in some environments where the function declaration was not available. This closes realm#8088
8 tasks
|
I started keeping a fork of this project and updating it on crucial issues. The first release fixed issues of building with NDK 29, which include this. Welcome to contribute to it. |
tgoyne
approved these changes
Dec 15, 2025
nirinchev
added a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Fix compilation issue by adding missing cstdlib header in cli_args.cpp. This resolves a build compatibility problem where
std::strtolfunction was used without including the proper header declaration, causing compilation failures in some environments.The fix ensures the code compiles correctly across different platforms and compiler versions by providing the proper declaration for the
std::strtolfunction used on line 67.This closes #8088
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary@realm/devdocsif documentation changes are needed