RCORE-2221 test to prove between node wrong behaviour over links #7940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicola-cab
commented
Aug 1, 2024
|
|
||
| // this is not working with colkey not found and it using the | ||
| // in between node. | ||
| auto q1 = parent->query("child.int BETWEEN {0,100}"); |
There was a problem hiding this comment.
Apparently we are not following the links, when we do:
auto min_val = min->visit(drv, type_Int);
auto max_val = max->visit(drv, type_Int);
q.between(obj_prop->column_key(), min_val->get_mixed().get_int(), max_val->get_mixed().get_int());
return q;
nicola-cab
commented
Aug 1, 2024
| const auto type = tmp->get_type(); | ||
| if (type == type_Int || type == type_Timestamp) { | ||
| if (obj_prop->links_exist()) { | ||
| const auto& link_map = obj_prop->get_link_map(); |
There was a problem hiding this comment.
This approach doesn't work because you are passing the destination column and the destination table, without accounting for the links along the way. The specialized between node doesn't handle links, so we can just fall back to a normal relational comparison below. I have opened #7965 to do it this way.
There was a problem hiding this comment.
Ok great! Probably we should have a test in core that tracks this, because if something is not working, some test should tell us!!! But again, thanks for spotting this.
There was a problem hiding this comment.
There is a test in #7965 which will catch this.
Pull Request Test Coverage Report for Build nicola.cabiddu_1886Details
💛 - Coveralls |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
In Between node fix follow links.
Note: needs a changelog
☑️ ToDos
bindgen/spec.yml, if public C++ API changed