Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCORE-1990 Get exact parity with Jenkins for UWP builders in evg #7937

Merged
merged 1 commit into from
Jul 31, 2024
Merged

RCORE-1990 Get exact parity with Jenkins for UWP builders in evg #7937

merged 1 commit into from
Jul 31, 2024

Conversation

jbreams
Copy link
Contributor

@jbreams jbreams commented Jul 31, 2024

What, How & Why?

In Jenkins we actually had two UWP builders:

  • Windows 64-bit UWP debug app build with Sync and encryption enabled
  • Windows 32-bit UWP release app build with Sync and encryption enabled

This makes the evergreen config match that.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@cla-bot cla-bot bot added the cla: yes label Jul 31, 2024
@jbreams jbreams requested a review from ironage July 31, 2024 18:06
ironage
ironage approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM when evergreen passes. 👍

@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build jonathan.reams_3389

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 116 unchanged lines in 23 files lost coverage.
  • Overall coverage decreased (-0.02%) to 91.095%
Files with Coverage Reduction New Missed Lines %
src/realm/array_string.cpp 1 88.03%
src/realm/query_expression.hpp 1 93.81%
src/realm/sync/noinst/server/server_history.cpp 1 62.92%
test/test_query2.cpp 1 98.73%
src/realm/cluster.cpp 2 75.85%
src/realm/object-store/shared_realm.cpp 2 91.89%
src/realm/sync/network/http.hpp 2 82.76%
src/realm/table_view.cpp 2 92.99%
test/object-store/util/test_file.cpp 2 86.47%
src/realm/mixed.cpp 3 86.46%
Totals Coverage Status
Change from base Build 2532: -0.02%
Covered Lines: 216809
Relevant Lines: 238002
💛 - Coveralls

@jbreams jbreams merged commit f35c76e into master Jul 31, 2024
50 of 52 checks passed
@jbreams jbreams deleted the jbr/uwp_jenkins_parity branch July 31, 2024 19:01
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ironage ironage ironage approved these changes

Assignees

@jbreams jbreams

Labels
cla: yes no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbreams @ironage