RCORE-2196 Use the Windows trusted root certificates for TLS #7882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build yavor.georgiev_443Details
💛 - Coveralls |
leemaguire
reviewed
Jul 12, 2024
| @@ -131,6 +131,8 @@ class Context { | |||
| /// default certificates for server verification. For OpenSSL, | |||
| /// use_default_verify() corresponds to | |||
| /// SSL_CTX_set_default_verify_paths(SSL_CTX*); | |||
| /// | |||
| /// On Windows this also adds a lookup to the system Trusted Root Certification Authorities list. | |||
There was a problem hiding this comment.
Is there a way to know if it failed to find certs for whatever reason so that you could fall back to m_ssl_context.use_included_certificate_roots();?
There was a problem hiding this comment.
The use_ methods are not mutually-exclusive. You can call as many as you like while you’re setting up your context.
Besides, looking up certificates happens during the SSL handshake, way after you’ve set up the context.
danieltabacaru
approved these changes
Jul 15, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
If an app runs in an enterprise environment where the machine is configured with a traffic-intercepting firewall any custom SSL certificates issued by the firewall need a new trusted root certificate to be installed on the machine. The interface we currently expose puts the onus on the app developer to provide us with a certificate we can add to the OpenSSL certificate store, but in such an environment the app developer is not able to do so.
What we can do to better conform is to automatically look up certificates in the machine's Trusted Root Certification Authorities store on OpenSSL's behalf and use them for the SSL handshake.
☑️ ToDos