Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update return type of LogCategory::get_category_names() from std::vector<const char*> to std::vector<std::string_view> #7879

Merged
merged 6 commits into from
Jul 12, 2024

Conversation

elle-j
Copy link
Contributor

@elle-j elle-j commented Jul 11, 2024

What, How & Why?

Updates the return type of LogCategory::get_category_names() from std::vector<const char*> to std::vector<std::string_view> in order to alleviate marshaling of strings in DotNet.

This also aligns better with LogCategory::get_category(std::string_view name) (already taking a std::string_view).

We don't believe this will be a breaking change.

SDK reviewers, please confirm if this is non-breaking/breaking for you.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
    • Remains unchanged.
  • bindgen/spec.yml, if public C++ API changed
    • This API was never exposed.

@elle-j elle-j marked this pull request as ready for review July 11, 2024 14:23
@elle-j elle-j requested a review from dianaafanador3 July 11, 2024 14:24
@elle-j elle-j added the no-jira-ticket Skip checking the PR title for Jira reference label Jul 11, 2024
Copy link

Pull Request Test Coverage Report for Build linnea.jansson_7

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • 98 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.981%

Files with Coverage Reduction New Missed Lines %
src/realm/array_mixed.cpp 1 94.02%
src/realm/index_string.hpp 1 93.48%
src/realm/util/serializer.cpp 1 90.43%
test/fuzz_tester.hpp 1 57.73%
test/test_dictionary.cpp 1 99.83%
test/test_table.cpp 1 99.51%
src/realm/list.cpp 2 87.37%
src/realm/object-store/shared_realm.cpp 2 91.89%
src/realm/sync/network/http.hpp 2 82.27%
test/test_lang_bind_helper.cpp 2 93.2%
Totals Coverage Status
Change from base Build 2483: -0.02%
Covered Lines: 215223
Relevant Lines: 236558

💛 - Coveralls

Copy link
Contributor

@clementetb clementetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any incompatibility with the Kotlin SDK.

@dianaafanador3
Copy link
Contributor

It is working as expected in Swift

@elle-j elle-j merged commit aa58e29 into master Jul 12, 2024
46 of 48 checks passed
@elle-j elle-j deleted the lj/category-names branch July 12, 2024 16:07
@github-actions github-actions bot mentioned this pull request Jul 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants