-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update return type of LogCategory::get_category_names()
from std::vector<const char*>
to std::vector<std::string_view>
#7879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build linnea.jansson_7Details
💛 - Coveralls |
clementetb
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find any incompatibility with the Kotlin SDK.
jedelbo
approved these changes
Jul 12, 2024
It is working as expected in Swift |
dianaafanador3
approved these changes
Jul 12, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Updates the return type of
LogCategory::get_category_names()
fromstd::vector<const char*>
tostd::vector<std::string_view>
in order to alleviate marshaling of strings in DotNet.This also aligns better with
LogCategory::get_category(std::string_view name)
(already taking astd::string_view
).We don't believe this will be a breaking change.
SDK reviewers, please confirm if this is non-breaking/breaking for you.
☑️ ToDos
bindgen/spec.yml
, if public C++ API changed