RCORE-2187 Prefix sync connection log messages with co_id when possible #7849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreams
force-pushed
the
jbr/coid_logging
branch
from
6bfa2c6
to
d7e061d
Compare
Pull Request Test Coverage Report for Build jonathan.reams_3347Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build jonathan.reams_3367Details
💛 - Coveralls |
danieltabacaru
approved these changes
Jul 12, 2024
| logger.base_logger = make_logger(m_ident, m_appservices_coid, get_client().logger.base_logger); | ||
|
|
||
| for (auto& [ident, sess] : m_sessions) { | ||
| sess->logger.base_logger = Session::make_logger(ident, logger.base_logger); |
There was a problem hiding this comment.
I guess it's not possible that a session may be logging something at the same time right?
|
@kmorkos, any thoughts here? |
kmorkos
approved these changes
Jul 24, 2024
|
@danieltabacaru , can you take another quick look at the test I added? |
danieltabacaru
approved these changes
Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This updates the logger used by sync Connections/Sessions to be prefixed with the app services co_id rather than the numeric conn ident counter when available. This lets us more easily correlate client logs to server logs. If the co_id is not available the behavior should be unchanged.
☑️ ToDos
bindgen/spec.yml, if public C++ API changed