-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCORE-2187 Prefix sync connection log messages with co_id when possible #7849
Conversation
6bfa2c6
to
d7e061d
Compare
Pull Request Test Coverage Report for Build jonathan.reams_3347Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build jonathan.reams_3367Details
💛 - Coveralls |
logger.base_logger = make_logger(m_ident, m_appservices_coid, get_client().logger.base_logger); | ||
|
||
for (auto& [ident, sess] : m_sessions) { | ||
sess->logger.base_logger = Session::make_logger(ident, logger.base_logger); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's not possible that a session may be logging something at the same time right?
@kmorkos, any thoughts here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, missed this request before. lgtm!
@danieltabacaru , can you take another quick look at the test I added? |
What, How & Why?
This updates the logger used by sync Connections/Sessions to be prefixed with the app services co_id rather than the numeric conn ident counter when available. This lets us more easily correlate client logs to server logs. If the co_id is not available the behavior should be unchanged.
☑️ ToDos
bindgen/spec.yml
, if public C++ API changed