RCORE-2168: Replicate clear instruction unconditionally for nested collections #7821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build jorgen.edelbo_319Details
💛 - Coveralls |
|
Can you add a summary in the description of the behavior these changes introduce? |
Done |
| @@ -6204,6 +6204,95 @@ TEST(Sync_DeleteCollectionInCollection) | |||
| } | |||
| } | |||
|
|
|||
| TEST(Sync_NestedCollectionClear) | |||
There was a problem hiding this comment.
Let's add the same test for dictionaries too
There was a problem hiding this comment.
I was hoping we can have the same schema with different scenarios as for lists (i.e, Dictionary vs Dictionary in Mixed)
There was a problem hiding this comment.
I am not sure what you mean. I have added a test case that fails without the fix that this PR provides.
There was a problem hiding this comment.
I meant that for lists you use all three Mixed fields in the schema in tests.
Pull Request Test Coverage Report for Build jorgen.edelbo_323Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build jorgen.edelbo_324Details
💛 - Coveralls |
| @@ -6204,6 +6204,95 @@ TEST(Sync_DeleteCollectionInCollection) | |||
| } | |||
| } | |||
|
|
|||
| TEST(Sync_NestedCollectionClear) | |||
There was a problem hiding this comment.
I was hoping we can have the same schema with different scenarios as for lists (i.e, Dictionary vs Dictionary in Mixed)
Pull Request Test Coverage Report for Build jorgen.edelbo_329Details
💛 - Coveralls |
danieltabacaru
approved these changes
Jun 28, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Fixes #7809
This change makes sure that a collection nested in a Mixed type always will contain the values that has been assigned to it by some client. Before this change you could end up having a combination of values assigned by different clients.
☑️ ToDos
bindgen/spec.yml, if public C++ API changed