Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the old pre-c++11 Thread implementation #7696

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

tgoyne
Copy link
Member

@tgoyne tgoyne commented May 14, 2024

This was a backport of std::thread to C++03 and we haven't needed it for a long time. std::thread doesn't expose set_name(), so that remains.

The other things in thread.hpp are still relevant for robust and process shared mutexes.

@tgoyne tgoyne added the no-jira-ticket Skip checking the PR title for Jira reference label May 14, 2024
@tgoyne tgoyne self-assigned this May 14, 2024
@cla-bot cla-bot bot added the cla: yes label May 14, 2024
Copy link

coveralls-official bot commented May 14, 2024

Pull Request Test Coverage Report for Build thomas.goyne_351

Details

  • 48 of 59 (81.36%) changed or added relevant lines in 6 files are covered.
  • 40 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.819%

Changes Missing Coverage Covered Lines Changed/Added Lines %
test/test_lang_bind_helper.cpp 9 11 81.82%
test/test_thread.cpp 15 24 62.5%
Files with Coverage Reduction New Missed Lines %
src/realm/index_string.cpp 1 85.17%
src/realm/query_expression.hpp 1 93.81%
src/realm/sort_descriptor.cpp 1 94.06%
src/realm/uuid.cpp 1 98.48%
src/realm/mixed.cpp 2 86.46%
src/realm/sync/network/http.hpp 2 82.27%
src/realm/sync/noinst/server/server.cpp 2 74.11%
test/test_lang_bind_helper.cpp 2 93.2%
src/realm/sync/noinst/protocol_codec.hpp 3 73.5%
test/fuzz_group.cpp 5 45.77%
Totals Coverage Status
Change from base Build 2327: 0.02%
Covered Lines: 214642
Relevant Lines: 236341

💛 - Coveralls

@tgoyne tgoyne requested a review from ironage May 20, 2024 18:17
@tgoyne tgoyne force-pushed the tg/delete-util-thread branch from 7908b66 to b989910 Compare May 21, 2024 19:19
@tgoyne tgoyne merged commit 37be840 into master May 21, 2024
37 checks passed
@tgoyne tgoyne deleted the tg/delete-util-thread branch May 21, 2024 20:39
@fealebenpae fealebenpae mentioned this pull request May 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants