Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bindgen] expose both SyncUser and app::User #7634

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Apr 26, 2024

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@kneth kneth requested a review from jedelbo April 26, 2024 11:31
@cla-bot cla-bot bot added the cla: yes label Apr 26, 2024
@kneth kneth added no-changelog no-jira-ticket Skip checking the PR title for Jira reference labels Apr 26, 2024
Copy link

Pull Request Test Coverage Report for Build kenneth.geisshirt_13

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 41 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.001%) to 90.752%

Files with Coverage Reduction New Missed Lines %
src/realm/sync/noinst/changeset_index.cpp 1 79.47%
test/fuzz_tester.hpp 1 57.73%
src/realm/sync/noinst/server/server.cpp 3 73.67%
src/realm/sync/noinst/server/server_history.cpp 3 63.57%
src/realm/util/assert.hpp 4 87.1%
src/realm/bplustree.cpp 6 72.55%
test/fuzz_group.cpp 23 47.21%
Totals Coverage Status
Change from base Build 2262: 0.001%
Covered Lines: 212228
Relevant Lines: 233854

💛 - Coveralls

@jedelbo jedelbo changed the base branch from master to prepare-14.6.0 April 26, 2024 13:24
@kneth kneth merged commit c071402 into prepare-14.6.0 Apr 26, 2024
38 of 44 checks passed
@kneth kneth deleted the kneth/bindgen/sync-and-app-user branch April 26, 2024 13:52
@michael-wb michael-wb mentioned this pull request Apr 26, 2024
michael-wb pushed a commit that referenced this pull request Apr 26, 2024
* Prepare release

* [bindgen] expose both SyncUser and app::User (#7634)

* RCORE-2060 Enabling 'cancel_waits_on_nonfatal_error' does not cancel waits during location update while offline (#7528)

* added tests using cancel_waits_on_nonfatal_error and fix operation during location update
* Updated changelog and updated comments/debug statements
* fix swift build and test and tsan errors
* Added test to replicate swift autoopen feature
* Fixed swift build issue
* removed an unused function
* Updates from review

---------

Co-authored-by: Kenneth Geisshirt <[email protected]>
Co-authored-by: Michael Wilkerson-Barker <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants