Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vendor support to Android blueprints #7614

Merged
merged 3 commits into from
May 21, 2024
Merged

Add vendor support to Android blueprints #7614

merged 3 commits into from
May 21, 2024

Conversation

leemaguire
Copy link
Contributor

@leemaguire leemaguire commented Apr 23, 2024 •
edited
Loading

This adds vendor support for Android Blueprints and is a prerequisite for RCPP-47

☑️ ToDos

  • 📝 Changelog update

@leemaguire leemaguire self-assigned this Apr 23, 2024
@cla-bot cla-bot bot added the cla: yes label Apr 23, 2024
@leemaguire leemaguire mentioned this pull request Apr 23, 2024
Merged
@leemaguire leemaguire requested a review from fealebenpae April 23, 2024 21:16
@leemaguire leemaguire marked this pull request as ready for review April 23, 2024 21:16
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Apr 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build lee.maguire_78

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 53 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.008%) to 90.798%
Files with Coverage Reduction New Missed Lines %
src/realm/mixed.cpp 1 86.61%
src/realm/sync/noinst/client_impl_base.cpp 1 82.38%
src/realm/sync/noinst/client_impl_base.hpp 1 93.16%
src/realm/util/file.cpp 1 78.73%
src/realm/util/serializer.cpp 1 90.43%
test/fuzz_tester.hpp 1 57.73%
src/realm/cluster.cpp 2 75.6%
src/realm/query_engine.cpp 3 92.36%
src/realm/unicode.cpp 3 83.83%
src/realm/sync/noinst/protocol_codec.hpp 4 73.32%
Totals Coverage Status
Change from base Build 2326: 0.008%
Covered Lines: 214738
Relevant Lines: 236502
💛 - Coveralls

@leemaguire leemaguire added the no-jira-ticket Skip checking the PR title for Jira reference label Apr 24, 2024
@leemaguire leemaguire merged commit 93d5fff into master May 21, 2024
35 of 37 checks passed
@leemaguire leemaguire deleted the lm/android-bp branch May 21, 2024 17:23
@fealebenpae fealebenpae mentioned this pull request May 23, 2024
Merged
dg0yt
dg0yt reviewed May 30, 2024
View reviewed changes
src/realm/object-store/util/scheduler.cpp
Comment on lines +36 to +40
#if REALM_ANDROID && !defined(REALM_AOSP_VENDOR)
#define HAS_ANDROID_ALOOPER
#endif

#if HAS_ANDROID_ALOOPER
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This expands either to

#if

or

#if HAS_ANDROID_ALOOPER

causing

/mnt/vcpkg-ci/b/realm-core/src/14.8.0-91fbc84ff4.clean/src/realm/object-store/util/scheduler.cpp:40:24: error: expected value in expression
#if HAS_ANDROID_ALOOPER

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dg0yt the latest master contains a fix for this where it becomes #if defined(HAS_ANDROID_ALOOPER)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dg0yt dg0yt dg0yt left review comments

@fealebenpae fealebenpae fealebenpae approved these changes

Assignees

@leemaguire leemaguire

Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leemaguire @fealebenpae @dg0yt