Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using stringops query on nested collections #7315

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Feb 5, 2024

What, How & Why?

Fixes #7282

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@cla-bot cla-bot bot added the cla: yes label Feb 5, 2024
@jedelbo jedelbo requested a review from ironage February 5, 2024 14:28
Copy link

Pull Request Test Coverage Report for Build jorgen.edelbo_62

  • 0 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 140 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.891%

Files with Coverage Reduction New Missed Lines %
src/realm/sync/network/network.cpp 1 89.86%
test/test_index_string.cpp 1 94.63%
test/test_query2.cpp 1 99.09%
src/realm/array_string.cpp 2 85.25%
src/realm/uuid.cpp 2 97.06%
test/test_lang_bind_helper.cpp 2 94.24%
src/realm/sort_descriptor.cpp 3 93.8%
test/test_thread.cpp 3 66.67%
src/realm/link_translator.cpp 4 76.0%
src/realm/mixed.cpp 4 86.31%
Totals Coverage Status
Change from base Build jorgen.edelbo_60: -0.02%
Covered Lines: 238408
Relevant Lines: 262300

💛 - Coveralls

@jedelbo jedelbo merged commit 05f73f6 into next-major Feb 6, 2024
39 checks passed
@jedelbo jedelbo deleted the je/query-mixed-stringops branch February 6, 2024 08:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants