Rename SyncUser::identity() to SyncUser::user_id() #7267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The word "identity" was used for two different concepts in SyncUser: `identity()` returned the server-assigned unique id for the User, while `identities()` returned information on the credentials used to log into the user. This was very confusing, so rename the first one to user_id (and update all the other places where identity was used for that).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dropped this from #6837 because it was sort of just unnecessary churn, but in the time since I've continued to find it confusing. SyncUser currently has both
identity()andidentities()which are two completely unrelated things: the first is the unique id for the user generated by the server, and the second is the set of credentials which have been used to log in the user. To fix this, I renamedidentity()touser_id()and aligned all of the related functions to that name, making it so that the word "identity" is only used for the SyncUserIdentity concept.