Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read/write same thread local storage #7195

Closed

Conversation

nicola-cab
Copy link
Member

What, How & Why?

Write/Read same thread local storage and pass user code data back to the right thread.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@nicola-cab nicola-cab force-pushed the nc/client_reset_callback_set_error_code_fix branch from aed4292 to f23c120 Compare December 8, 2023 17:51
Copy link

Pull Request Test Coverage Report for Build nicola.cabiddu_1205

  • 16 of 16 (100.0%) changed or added relevant lines in 4 files are covered.
  • 80 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.009%) to 91.711%

Files with Coverage Reduction New Missed Lines %
src/realm/object-store/shared_realm.cpp 2 93.04%
src/realm/sync/noinst/server/server_history.cpp 2 67.94%
src/realm/table_view.cpp 2 94.18%
src/realm/sync/noinst/protocol_codec.hpp 3 76.72%
src/realm/util/serializer.cpp 3 90.03%
src/realm/sync/noinst/server/server.cpp 4 76.83%
src/realm/util/assert.hpp 4 87.1%
src/realm/index_string.cpp 6 87.81%
src/realm/cluster_tree.cpp 7 91.8%
src/realm/sync/instruction_applier.cpp 7 70.26%
Totals Coverage Status
Change from base Build 1907: 0.009%
Covered Lines: 232225
Relevant Lines: 253214

💛 - Coveralls

@nicola-cab
Copy link
Member Author

I don't know if there is any interest in pursuing this PR, so I am closing this for now. In case we decide, we want to explore this path, we can always re-open it.

@nicola-cab nicola-cab closed this Jan 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant